Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556556 --- Comment #5 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2010-02-03 05:37:14 EST --- Review: OK: rpmlint must be run on every package. Output: geronimo-parent-poms.noarch: E: devel-dependency maven2-plugin-source False positive, ignore it. geronimo-parent-poms.noarch: W: no-documentation Nothing suitable, ignore it. SPECS/geronimo-parent-poms.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 26, tab: line 3) Not a blocker but will be nice to fix it. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Packages must not own files or directories already owned by other packages. OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} OK: All filenames in rpm packages must be valid UTF-8. Please remove %config(noreplace) from the _mavendepmapfragdir line in %files. I know that this creates an rpmlint warning but depmap files are supposed to be replaced everytime a package is installed/updated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review