Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551265 Nicoleau Fabien <nicoleau.fabien@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Nicoleau Fabien <nicoleau.fabien@xxxxxxxxx> 2010-02-02 17:32:16 EST --- Package revienw : [OK] Package is named according to the Package Naming Guidelines [OK] Specfile name matches %{name}.spec [OK] Package seems to meet Packaging Guidelines [OK] Package successfully compiles and builds into binary RPMs on at least one supported architecture : Builds on koji [OK] Rpmlint output: the warning about "noreplace" config file can be ignored [OK] Package is not relocatable. [OK] License in specfile matches actual License and meets Licensing Guidelines [OK] License file is included in %doc. [OK] Specfile is legible and written in AE [OK] Sourcefile in the Package is the same as provided in the mentioned Source [OK] Package compiles successfully [OK] All build dependencies are listed in BuildRequires [N/A] Specfile handles locales properly [N/A] ldconfig called in %post and %postun if required [N/A] Package owns directorys it creates [OK] Package requires other packages for directories it uses. [OK] Package does not list a file more than once in the %files listing [OK] %files section includes %defattr and permissions are set properly [OK] %clean section is there and contains rm -rf %{buildroot} [OK] Macros are consistently used [OK] Package contains code, or permissable content. [N/A] Large documentation files are in a -doc subpackage [OK] Program runs properly without files listed in %doc [N/A] Header files are in a -devel package [N/A] Static libraries are in a -static package [N/A] Package requires pkgconfig if .pc files are present [N/A] .so-files are put into a -devel subpackage [N/A] Subpackages include fully versioned dependency for the base package [N/A] Any libtool archives (*.la) are removed [N/A] contains desktop file (%{name}.desktop) if it is a GUI application [OK] Package does not own files or directories owned by other packages. [OK] %{buildroot} is removed at beginning of %install [N/A] Filenames are encoded in UTF-8 Also GConf rules are respected : http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf This package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review