Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=559699 --- Comment #2 from Fabio Massimo Di Nitto <fdinitto@xxxxxxxxxx> 2010-02-02 08:43:54 EST --- Hi Nuno, the new package introduces a lot of changes compared to what is in fedora-cvs qpidc/devel. It would be a lot simpler if the srpm/spec file to review contains _only_ the changes related to the rename process otherwise every added change has to be re-reviewed. The question I have for you (for eg.): (from qpidc) %package -n %{srv}-cluster becomes: (from the new one) %package -n %{name}-server-cluster Obsoletes: qpidd-cluster but there is no Provides: entry. I suggest for you to review: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Renaming.2Freplacing_existing_packages and if the entries in the new spec files are correct, then add a note that the new package does not fully replace the old one. Thanks Fabio -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review