[Bug 210183] Review Request: ballbuster - Move the paddle to bounce the ball and break all the bricks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ballbuster - Move the paddle to bounce the ball and break all the bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210183





------- Additional Comments From j.w.r.degoede@xxxxxx  2006-10-10 16:59 EST -------
Hi guys,

Phew lots of comments. Anyways thanks for the review I'll import it and get it
build.

To answerboth your questions:
1) "Requires: hicolor-icon-theme", must be present in any package which installs
files under /usr/share/icons/hicolor/XxX/apps. I know many packages
don't Require it but that could lead to an empty unowned directory staying
behind on package removal. About the problem of this package getting removed
after hicolor-icon-theme and thus still leaving an empty unowned directory
behind. That isn't possible because rpm (should) order erases to first erase
this package and only then erase any package requiring it. In practice this
doesn't happen due to an rpm bug hence the "(should)", but this bug has been on
the to fix list for a while so maybe it is fixed now. Either it was decided to
ignore this bug and create packages which work with a proper rpm, as avoiding
this problem with the rpm bug present is impossible.

2) The "touch --nocreate" is correct and nescesarry and must be outside the if
   the desktop.org standard /usr/share/icons icons and /usr/share/applications
   are used by other non GTK desktop environments such as KDE too, these don't
   have an in tree icon cache like GTK has, but instead check the timestamp of
   the upper directory of the iocn hierarchy.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]