Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560456 --- Comment #3 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2010-02-01 11:22:49 EST --- (In reply to comment #2) > Thanks for putting this package together. I noticed that Fedora ships a Python > 2 version of this module; see: > https://admin.fedoraproject.org/pkgdb/packages/name/python-smbpasswd [snip] > Given that both Python 2 and Python 3 support can be built from identical > sources, I feel that it would be better to integrate the Python 3 support into > the pre-existing Python 2 SRPM as a new subpackage, rather than to create a new > SRPM. See the notes on > https://fedoraproject.org/wiki/PackagingDrafts/Python3 > for rationale, and our current ideas on the best ways of doing this. Again, > it's good to provide an example that shows the code working when requesting the > change this time from the Fedora package maintainer. I looked at the specfile %changelog, and realize now that you're the Fedora maintainer for the Python 2 version of this package. Given how minimal the changes needed to port this were, I still think that the best approach here is to add a python3- subpackage to the existing python-smbpasswd.spec (sending the upstream maintainer the patch). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review