Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560240 --- Comment #4 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-02-01 04:50:22 EST --- > automake/aclocal are not needed since I didn't modified Makefile.am, > acinclude.m4' or configure.in. I refer to regenering the autotools framework _prior to_ creating the source tarball. For example, configure.in is newer than configure. Hence the source tarball is mispackaged and also triggers warnings. > Should the license for libxls be changed to LGPLv3 and BSD with advertising? Yes, "LGPLv3+ and BSD with advertising". Upstream should get rid of src/getopt.c and replace it with something less troublesome. > I think its we can skip those warnings, it can works fine because > "typedef unsigned long DWORD" Where did you find that? Here it uses uint32_t, which is unsigned and 32-bit. So, %u not %ld. There are many more compiler warnings: http://koji.fedoraproject.org/koji/getfile?taskID=1953267&name=build.log A few excerpts with reason to be worried: xls2csv.c:182: warning: comparison with string literal results in unspecified behavior xls.c:390: warning: overflow in implicit constant conversion xlstool.c:447: warning: zero-length gnu_printf format string xlstool.c:456: warning: format '%.*s' expects type 'char *', but argument 4 has type 'WORD *' xlstool.c:489: warning: spurious trailing '%' in format xlstool.c:578: warning: embedded '\0' in format -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review