Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ballbuster - Move the paddle to bounce the ball and break all the bricks https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210183 mr.ecik@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jima@xxxxxxxxxxxxxx |mr.ecik@xxxxxxxxx ------- Additional Comments From mr.ecik@xxxxxxxxx 2006-10-10 15:26 EST ------- (In reply to comment #5) > I think (and I could be wrong) that you might need to change > > Requires: hicolor-icon-theme > > to: > > Requires(post): hicolor-icon-theme > Requires(postun): hicolor-icon-theme > > as I believe that package explicitly needs to be installed during both the > post/postun commands. I don't think so. hi-color-icon-theme need to be installed because if you removed that package, it would cause removing of ballbuster.png too (theoretically). So using it as Requires is good. Now it doesn't make doubt for me. > Out of curiosity, does `touch --no-create %{_datadir}/icons/hicolor` need to be > run if gtk2 isn't installed? If not, you might want to move that command to > within the if block; if so, disregard. :-) It will be run if gtk2 isn't installed, but it won't cause any errors due to use of " || ;". Read http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?#head- 7103f6c38d1b5735e8477bdd569ad73ea2c49bda for more informations > hicolor-icon-theme is required because it owns the directory > /usr/share/icons/hicolor/32x32/apps/ballbuster.png (one of this package's files) > lives in. (Well, strictly speaking, so do four other packages in Core, and > seven in Extras, but I think it might be the directory's rightful owner.) Yeah, you're right, thanks to point that > MichaÅ‚ (ack, does that even paste sanely?): As I said, I haven't even started a > proper review, so you're welcome to take over. My first name should be proper written as "Michał" ;) So okay, I'll review it in next comment. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review