Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533167 Siddhesh Poyarekar <spoyarek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spoyarek@xxxxxxxxxx --- Comment #1 from Siddhesh Poyarekar <spoyarek@xxxxxxxxxx> 2010-01-30 15:16:40 EST --- I'm not a sponsor/provenpackager, so this is an unofficial review: * use %global instead of %define http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * The following is not required since info is considered part of the minimal build environment: > Requires(post): /sbin/install-info > Requires(preun): /sbin/install-info http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 * make should have %{?_smp_mflags}. If the package fails to build due to this, you need to put in a comment mentioning that http://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review