Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551724 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx Flag| |fedora-review? Bug 551724 depends on bug 551722, which changed state. Bug 551722 Summary: Review Request: php-channel-phpmd - PHP Mess Detector PEAR channel https://bugzilla.redhat.com/show_bug.cgi?id=551722 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|NEW |CLOSED --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-01-30 12:29:46 EST --- First/quick notes - Replace %define by %global (I have miss this on previous reviews...) - use %{channel} in %postun - use %{pear_datadir} instead of %{pear_phpdir}/data All docs should be in /usr/share/doc/php-phpmd-PHP-PMD-0.2.1 Most of pear package use (what is generated by pear make-rpm-spec): after install: mv $RPM_BUILD_ROOT%{pear_docdir}/* docdir and in %file %doc %{pear_name}-%{version}/docdir/%{pear_name}/* In fact, Guidelines need to be clearer about this, so Waiting for a reply to http://lists.fedoraproject.org/pipermail/packaging/2010-January/006845.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review