Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551723 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-01-30 03:05:15 EST --- REVIEW: + rpmlint is ok php-pdepend-PHP-Depend.src: I: checking php-pdepend-PHP-Depend.noarch: I: checking php-pdepend-PHP-Depend.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines + License ok : BSD + License is upstream + spec in english and legible + license file not provided + sources match the upstream sources d1e686b555f62f39cfce830a40d5d675 PHP_Depend-0.9.9.tgz + Source URL ok + build on F12.x86_64 + BuildRequires (php-pear >= 1:1.6.0, php-channel(pear.pdepend.org)) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + small documentation not required to run + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + test suite ok (can't be run during build) + scriptlets ok + Final Requires ok /usr/bin/pear /usr/bin/php php-channel(pear.pdepend.org) php-common >= 5.2.2 php-pecl(imagick) >= 2.2.0b2 php-xml + Final Provides ok php-pear(pear.pdepend.org/PHP_Depend) = 0.9.9 php-pdepend-PHP-Depend = 0.9.9-2.fc8 + Build in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1953005 You could remplace Requires: php-common >= 5.2.2 Requires: php-xml With a single Requires: php-xml >= 5.2.2 =========== APPROVED =========== -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review