Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558685 Julian Sikorski <belegdol@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |belegdol@xxxxxxxxx Flag| |fedora-review? --- Comment #3 from Julian Sikorski <belegdol@xxxxxxxxx> 2010-01-29 17:25:39 EST --- 1. --libdir=%{_libdir} is unnecessary. 2. find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' is a less cluttered way to get rid of libtool archives. 3. make install %{_libdir} DESTDIR=$RPM_BUILD_ROOT is most likely incorrect. 4. The homepage is actually https://launchpad.net/gloobus-preview. 5. You might want to use one more %{version} macro in the source url. Also, wouldn't it be possible to ship a gconf schema with the entries readme is asking to create? Not that many users really read the documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review