Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=559818 --- Comment #3 from Thomas Janssen <thomasj@xxxxxxxxxxxxxxxxx> 2010-01-29 10:17:15 EST --- Acknowledge for the re-review request (due to the upstream name change). OK- Package meets naming and packaging guidelines OK- Spec file matches base package name. OK- Spec has consistant macro usage. OK- Meets Packaging Guidelines. OK- License GPLv2+ OK- License field in spec matches OK- License file included in package OK- Spec in American English OK- Spec is legible. OK- Sources match upstream md5sum: b8852fa0eafd6a771f8a036224bcba4f NN- Package needs ExcludeArch OK- BuildRequires correct NN- Spec handles locales/find_lang OK- Package has %defattr and permissions on files is good. OK- Package has a correct %clean section. OK- Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) OK- Package is code or permissible content. OK- Doc subpackage not needed. OK- Packages %doc files don't affect runtime. OK- Headers/static libs in -devel subpackage. OK- Spec has needed ldconfig in post and postun OK- .so files in -devel subpackage. OK- -devel package Requires: %{name} = %{version}-%{release} OK- .la files are removed. OK- Package compiles and builds on at least one arch. OK- Package has no duplicate files in %files. OK- Package doesn't own any directories other packages own. OK- Package owns all the directories it creates. XX- No rpmlint output. [thomas@tusdell mock-test]$ rpmlint drumstick-* drumstick.x86_64: W: incoherent-version-in-changelog 0.2.99-0.1.svn20100107 ['0.2.99-0.1.fc12.20100107svn', '0.2.99-0.1.20100107svn'] drumstick-devel.x86_64: W: no-documentation drumstick-examples.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 3 warnings. [thomas@tusdell srpm-review-test]$ rpmlint drumstick.spec drumstick-0.2.99-0.1.fc13.20100107svn.src.rpm Error checking signature of drumstick-0.2.99-0.1.fc13.20100107svn.src.rpm: drumstick-0.2.99-0.1.fc13.20100107svn.src.rpm: (SHA1) DSA sha1 md5 (GPG) NOT OK (MISSING KEYS:GPG#1634f842) 1 packages and 1 specfiles checked; 0 errors, 0 warnings. SHOULD Items: OK- Should build in mock. OK- Should build on all supported archs OK- Should have sane scriptlets. OK- Should have subpackages require base package with fully versioned depend. OK- Should package latest version NN- check for outstanding bugs on package. (For core merge reviews) Obsoletes and Provides are reviewed and sane. Issues: 1. You might fix the incoherent version in %changelog. The rest of rpmlint output can be ignored. APPROVED -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review