Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-10-10 12:16 EST ------- First review of this package: 1. From http://fedoraproject.org/wiki/Packaging/Guidelines: * Licensing = Okay, this package actually seems to be licensed under MIT. * Requires: Would you explain why this package should have Provides: %{name}-devel = %{version}-%{release} ? (If this must be as such, this package should also provide: xorg-x11-%{name}-devel ?) * Using %{buildroot} vs $RPM_BUILD_ROOT. - Use one, not both. * File and Directory Ownership : - %{_includedir}/X11/bitmaps/ is owned by xorg-x11-xbitmaps. If this package requires xbitmaps (would you explain why?), owning this directory is not needed for this package. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review