Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551258 --- Comment #6 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-01-28 16:05:23 EST --- > > File "INSTALL" is irrelevant to RPM package users. > > Fixed. Install added as a doc for development subpackage. It is irrelevant to RPM package users. It explains how to compile libgcal. [%check] > Yes, but I had some problems so thought to overlook. > If it is really important I could give it another shot... Well, "BuildRequires: check-devel" plus --enable-check plus "make check", and here the first test makes glibc find a realloc problem. Surely that is something to look into. Upstream should tell you whether this release is expected to pass the test-suite. > when is that I have to manually specify Requires and > when it's better to let them be picked up by rpm? In Fedora 11 and newer, rpmbuild examines .pc files for dependencies on other .pc files. Example: $ grep Req libgcal.pc Requires: libcurl libxml-2.0 $ rpm -qpR libgcal-devel-0.9.3-2.fc12.i686.rpm | grep pkg /usr/bin/pkg-config pkgconfig <-- this is your manual one pkgconfig(libcurl) pkgconfig(libxml-2.0) The dependencies on /usr/bin/pkg-config, libcurl.pc and libxml-2.0.pc are added by rpmbuild. On older platforms, rpmbuild doesn't do this. And where the pkgconfig .pc file does not specify dependencies, it may be necessary to add them to your .spec file manually (by examining C/C++ header files for needed dependencies). > mkdir -p %{buildroot}/usr/include/libgcal > > mv %{buildroot}/usr/include/*.h %{buildroot}/usr/include/libgcal/ > > but I'm not sure this is the best way to do it. This is incomplete, because libgcal.pc still thinks the files are found in /usr/include. Please talk to upstream about this. [One cannot move header file locations without either adjusting all "#include <...>" statements or header search paths.] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review