Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532527 David A. Wheeler <dwheeler@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dwheeler@xxxxxxxxxxxx --- Comment #1 from David A. Wheeler <dwheeler@xxxxxxxxxxxx> 2010-01-27 18:57:16 EST --- Hi - I'm looking over your package now. Looking at the Java guidelines: https://fedoraproject.org/wiki/Packaging/Java This spec doesn't say, per a MUST, that: It says that "At a minimum, Java packages MUST..." BuildRequires: java-devel [>= specific_version] Requires: java >= specific_version Requires: jpackage-utils It ends up having "Requires: jpackage-utils" through dependencies, and "ant" ends up forcing a BuildRequires on java-devel, but I think it'd be better to explicitly meet this guideline. The Java guidelines also (still) recommend adding the GCJ bits. Can you add them? (Frankly, I think it's a legitimate question to ask if this SHOULD is appropriate... but as long as it's a guideline, I feel I should make that request.) It built fine, and with no rpmlint warnings/errors: rpmlint junit-addons.spec ../RPMS/noarch/junit-addons-* ../SRPMS/junit-addons-1.4-5.fc12.src.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review