[Bug 559117] Review Request: lcdtest - display test pattern generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=559117

--- Comment #7 from Eric Smith <eric@xxxxxxxxxxxx> 2010-01-27 15:06:28 EST ---
OK.  Regarding the icon, I'll move it into /usr/share/pixmaps as recommended,
but I thought I'd point out why I put it in /usr/share/icons/hicolor in the
first place.  From the freedesktop.org Icon Theme Specification:

http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-0.11.html

"So, you're an application author, and want to install application icons so
that they work in the KDE and Gnome menus. Minimally you should install a 48x48
icon in the hicolor theme. This means installing a PNG file in
$prefix/share/icons/hicolor/48x48/apps."

I can't see any way to interpret this that allows for the hicolor theme to be
optional; it seems that if Fedora intends to be compliant with freedesktop.org
standards, the hicolor theme *must* be provided.

Anyhow, I'm not pushing for any change in Fedora policy, but since Fedora icon
policy differs from the freedesktop.org standard, it might be desirable to
update the desktop section of the packaging policy to explicitly state that the
basic fedora icon requirement is to use /usr/share/pixmaps.  That might prevent
another novice packager from making the same mistake I did.

Here's the updated lcdtest package:

Spec URL:
http://www.brouhaha.com/~eric/software/fedora/f12/lcdtest/lcdtest.spec
SRPM URL:
http://www.brouhaha.com/~eric/software/fedora/f12/lcdtest/lcdtest-1.18-2.fc12.src.rpm
Koji scratch build for f12-dist:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1948905

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]