Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: itpp - C++ library for math, signal/speech processing, and communications https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207782 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-10-10 11:14 EST ------- (In reply to comment #22) > So, getting back to the actual review, are there any blockers left > here? Well, * %{_datadir}/%{name}/ is not owned by any package. Main package should own this. (In reply to comment #24) > these warnings can be hard to get rid of sometimes. For this package, this can be resolved by following: ------------------------------------ ................. %configure --with-blas="-latlas -lblas" --disable-dependency-tracking \ --with-docdir=%{_docdir}/%{name}-%{version} --disable-static sed -i -e 's|-lgcc_s|-lgcc_s -lstdc++|' config.status ./config.status make %{?_smp_mflags} ................. ------------------------------------ ... and as this is actually a bug and can be fixed as above, this bug should be fixed before releasing in FE. * Well, (In reply to comment #16) > > > Re: comment #13 > > > deps for -devel > > Related to shared lib undefined symbols, the *library* ought to link against all > > those things, not itpp-using apps, they ought need only: > > -litpp > > Explicit linking against external libraries are always needed when > header files in the library use some types, > structure or so which are defined by other packages then the > header files include other external header files. > ( I have not checked if this package falls under this case). As I said, explicit linking is needed when header files includes other header files which are in other packages. I checked this package by: ( for f in `rpm -ql itpp-devel` ; do cat $f 2>/dev/null | grep '^#[ \t]*include' | sed -e 's|^[ \t][ \t]*||' | sed -n -e 's|.*<\(.*\)>.*|\1|p' ; done ) | sort | uniq and it seems it is not a case for this package. Then as Rex said in the comment #14, I doubt that itpp.pc and itpp-config should have: "-lfftw3 -llapack -latlas -lblas -L/usr/lib/atlas -lgfortranbegin -lgfortran -lm -lgcc_s -lstdc++" . Please check if this linkage is truly required. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review