Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556404 Jaroslav Škarvada <jskarvad@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #1 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> 2010-01-27 04:10:20 EST --- MUST items: [NO] rpmplint is silent perl-MIME-Lite.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 14) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. [YES] Package meets naming guidelines. [YES] Package meets packaging guidelines. [YES] Spec file matches base package name. [NO] License file is present, matching with spec file. Comment 1) [YES] Licensing Guidelines are met. [YES] Spec file is legible and in American English. Comment 2) [YES] Sources match upstream. [YES] Package builds OK. [YES] BuildRequires is correct. [YES] Package doesn't bundle copies of system libraries. [YES] Package owns all the directories it creates. [NO] Package has no duplicity in %files. Comment 3) [YES] Permission on files are set properly. [YES] %clean section is correct. [YES] Spec file has consistant macro usage. [YES] Package is code or permissable content. [YES] %doc files don't affect runtime. [YES] No .la libtool archives. [YES][Perl] Package doesn't own files/directories that other packages own. [YES] Package has rm -rf $RPM_BUILD_ROOT at beginning of %install. [YES] Spec file is valid UTF-8. Should items: [YES] Package builds in mock. [YES] Package uses sane scriptlets. [YES] Package contains man pages. **Comments: 1) COPYING and LICENSE files are not packaged into RPM. 2) In %description second sentence should start with capital letter. There is extra space after second sentence. 3) changes.pod is installed two times: -rw-r--r-- /usr/share/doc/perl-MIME-Lite-3.027/changes.pod -r--r--r-- /usr/share/perl5/MIME/changes.pod -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review