Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551723 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx Flag| |fedora-review? Bug 551723 depends on bug 551721, which changed state. Bug 551721 Summary: Review Request: php-channel-pdepend - PHP Depend PEAR channel https://bugzilla.redhat.com/show_bug.cgi?id=551721 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |ERRATA --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-01-26 13:22:29 EST --- First notes (before review): - According to package.xml and "pci" command result, it requires php-xml (dom + simpleXML) - directory /usr/share/pear/PHP is not owned - should use %{channel} in %postun to have consistent use of macros Optional deps : it's your choice to include this, or not > PHP_Depend-0.9.9 can optionally use package "pecl/imagick" (version >= 2.2.0b2) As this package is available, you could add Requires: php-pecl(imagick). A comment about this as "optionnal" seems usefull. If you don't want to add it, please add a note in the package description. Why do you remove test from RPM ? Adding %{pear_testdir}/%{pear_name} seems usefull (nothing on the Guidelines about this, but most of pear packages which provides tests keep it bundled) Do you know how to run the test suite providesd? I've try (but most fails) $ cd /usr/share/pear/test/PHP_Depend/tests/PHP/Depend/ $ phpunit AllTests (it's also a good idea, if you couldn't run it during build to add a comment about how to run it in your spec) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review