Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558550 Jonathan Dieter <jdieter@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #2 from Jonathan Dieter <jdieter@xxxxxxxxx> 2010-01-25 14:25:20 EST --- SHA256SUM: d253e6ff6624639aded67c82df98b2bc4a66eb66400848d5614921d513540cf9 from SRPM d253e6ff6624639aded67c82df98b2bc4a66eb66400848d5614921d513540cf9 from http://intellinuxwireless.org/iwlwifi/downloads/iwlwifi-5150-ucode-8.24.2.2.tgz Good: * The package is named according to the Package Naming Guidelines. * The spec file name matches the base package. * The package meets the Packaging Guidelines. * The package is licensed with a Fedora approved license (Redistributable, no modification permitted - acceptable for firmware) * The License field in the package spec file matches the actual license. * LICENSE is included in %doc. * The spec file is written in American English. * The spec file for the package is legible. * The sources used to build the package matches the upstream source. * The package successfully compiles and builds into binary rpm on i386. * All build dependencies are listed in BuildRequires. * The package owns all directories that it creates. * The package doesn't contain any duplicate files in the %files listing. * Permissions on files are set properly. * The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. * The package consistently uses macros. * The package contains code and permissable content. * All %doc files do not affect the runtime of the application. * At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT). * All filenames in rpm packages are valid UTF-8. * Source URL is canonical * Buildroot has all required elementsx * All necessary BuildRequires listed * All desired features are enabled * Group Tag is from the official list Bad: * All paths begin with macros - firmware is installed directly into /lib/firmware rather than %lib/firmware, but I'm assuming this is necessary as it lives in the same place on 32 and 64 bit architectures? Based on the assumption above, I'm listing this as approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review