Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541072 Rob Crittenden <rcritten@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #4 from Rob Crittenden <rcritten@xxxxxxxxxx> 2010-01-25 14:08:55 EST --- Review: + package builds in mock. + rpmlint is silent for SRPM + rpmlint warns about Default-Start/Default-Stop in RPM but I agree with Nalin that this is correct per the packaging guidelines: "More commonly, the service does not start by default in any runlevel. In this case, the line should be omitted." + source files match upstream (sha256sum) 0e1f0e966c17c2e6058ce7152cbb9d167ae42065ec9c45694ca7c75629ff98a8 certmonger-0.17.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use consistent. + Compiler flags are honored correctly. + Package contains code. + no static libraries. + no .pc file present. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + buildroot is cleaned in %install APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review