Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551914 Christian Krause <chkr@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chkr@xxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |chkr@xxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Christian Krause <chkr@xxxxxxxxxxx> 2010-01-24 12:46:07 EST --- Please can you always add a link to the spec file as well? Thanks! I've roughly scanned over the package and I've seen a couple of issues. It would be good if they could be fixed first before I do the full complete review: - source files differ from upstream: sources in package: 430571024f88c87d5104121739c6ab7e SOURCES/monodevelop-database-2.2.tar.bz2 sources from upstream (using the URL which was supplied in the spec file) 5bb1b77221066d57ff3ec58435a24bc3 monodevelop-database-2.2.tar.bz2 - the source URL does not match the link on the download page: http://ftp.novell.com/pub/mono/sources/monodevelop-database/monodevelop-database-2.2.tar.bz2 (this should fix the previous issue as well) - package does not build in koji - probably a missing build requirement: checking for GLIB_SHARP... configure: error: Package requirements (glib-sharp-2.0 >= 2.12.8) were not met: No package 'glib-sharp-2.0' found Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables GLIB_SHARP_CFLAGS and GLIB_SHARP_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. error: Bad exit status from /var/tmp/rpm-tmp.Z9lbEA (%build) Bad exit status from /var/tmp/rpm-tmp.Z9lbEA (%build) - some rpmlint warnings: SPECS/monodevelop-database.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 14) - directory %{_libdir}/monodevelop/AddIns/MonoDevelop.Database should be included in the package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review