Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554219 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-01-23 22:08:04 EST --- Review: Good: - name ok - group ok - no static libs - no *.la - %clean there - %files ok - permissions ok - license ok (when added the headers) Needswork: - parallel make: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - Not all files have headers and there is no COPYING file. Please add them upstream. Then there will be a %doc too. - BR not ok: There is no xorg-x11-server-sdk anymore. This was replaced by xorg-x11-sersver-devel, so please use that directly. - rpmlint:$ rpmlint xorg-x11-drv-qxl-0.0.6-0.1.fc12.src.rpm x86_64/xorg-x11-drv-qxl-* - source does not match upstream: your one: 0f721feee12fe8bba7bf3c66f3dbef07 upstream: 0779efb10e30daf33187aea2ae219094 (Maybe just the timestamp, didn't check that, you could add 'timestamping = on' to ~/.wgetrc to permanently enable timestamp preserving) - please use make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' to preserve timestamps. xorg-x11-drv-qxl.src: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 3) xorg-x11-drv-qxl.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review