Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555986 Christof Damian <christof@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #2 from Christof Damian <christof@xxxxxxxxxx> 2010-01-23 08:42:00 EST --- As it is just a rename of a package it already follows the guidelines, but I did a full review anyway because of the version change. I have also attached a diff between the spec file of the old package in rawhide and the new package. MUST: OK: package has the correct Provides and Obsolete to replace the old package as stated in the Packaging:Naming Guidelines OK: rpmlint must be run on every package. 1 packages and 1 specfiles checked; 0 errors, 0 warnings. OK: The package must be named according to the Package Naming Guidelines OK: The spec file name must match the base package %{name} OK: The package must meet the Packaging Guidelines OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: All filenames in rpm packages must be valid UTF-8. SHOULD: OK: The reviewer should test that the package builds in mock. OK: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. Package installs fine with yum on Fedora 12 and replaces the old package: =============================================================================== Package Arch Version Repository Size ================================================================================ Installing: php-phpunit-PHPUnit noarch 3.4.7-1.fc12 /php-phpunit-PHPUnit-3.4.7-1.fc12.noarch 2.0 M replacing php-pear-PHPUnit.noarch 3.3.17-1.fc12 Installing for dependencies: php-soap x86_64 5.3.1-1.fc12 updates 135 k I also tested it on the sample tests. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review