[Bug 549296] Review Request: lshell - Python-based limited Shell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549296

Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur@xxxxxxxxxxxxxxxxx
             Blocks|                            |530636(Python3F13)
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |tomspur@xxxxxxxxxxxxxxxxx
               Flag|                            |fedora-review?

--- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-01-22 13:22:58 EST ---
This builds just fine with python3, because you don't need to have
python-setuptools (the egg is builded by distutils).

How about building python3 only?

If you want to package this for F-12 and/or EPEL you need to be more explicit,
see
https://fedoraproject.org/wiki/PackagingDrafts/Python3#Guidelines_for_adding_python3_subpackages_to_an_existing_package


$ diff -u lshell.spec py3.spec 
--- lshell.spec 2009-12-21 09:53:01.000000000 +0100
+++ py3.spec 2010-01-22 14:39:42.835184038 +0100
@@ -1,5 +1,3 @@
-%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
-
 Name:           lshell
 Version:        0.9.8
 Release:        1%{?dist}
@@ -12,8 +10,7 @@
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:      noarch

-BuildRequires:  python-devel
-BuildRequires:  python-setuptools
+BuildRequires:  python3-devel


 %description
@@ -27,15 +24,18 @@
 chmod -x CHANGES
 #Remove shebang
 sed -i -e '/^#!\//, 1d' lshellmodule/lshell.py
+# Add python3 shebang
+sed -i -e 's|^#!/usr/bin/env python|#!/usr/bin/python3|g' bin/lshell


 %build
-%{__python} setup.py build
+2to3-3 -w .
+%{__python3} setup.py build


 %install
 rm -rf %{buildroot}
-%{__python} setup.py install -O1 --skip-build --root=%{buildroot}
+%{__python3} setup.py install -O1 --skip-build --root=%{buildroot}
 #doc files at the wrong place
 rm %{buildroot}%{_defaultdocdir}/lshell/{CHANGES,COPYING,README}

@@ -50,8 +50,8 @@
 %{_mandir}/man*/*.gz
 %{_bindir}/lshell
 %config(noreplace) %{_sysconfdir}/lshell.conf
-%{python_sitelib}/lshell.py*
-%{python_sitelib}/lshell*.egg-info
+%{python3_sitelib}/lshell.py*
+%{python3_sitelib}/lshell*.egg-info


 %changelog

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]