Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530473 --- Comment #22 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> 2010-01-21 13:51:09 EST --- lessfs.src: W: mixed-use-of-spaces-and-tabs (spaces: line 19, tab: line 1) lessfs.i586: W: unstripped-binary-or-object /usr/bin/lessfs 1) lessfs.i586: W: unstripped-binary-or-object /usr/sbin/listdb lessfs.i586: W: unstripped-binary-or-object /usr/sbin/mklessfs lessfs.i586: W: unstripped-binary-or-object /usr/sbin/defrag_lessfs lessfs.i586: W: unstripped-binary-or-object /usr/sbin/lessfsck lessfs.i586: W: spurious-executable-perm /usr/share/doc/lessfs-1.0.0/authors lessfs.i586: W: spurious-executable-perm /usr/share/doc/lessfs-1.0.0/README.crypto lessfs.i586: W: spurious-executable-perm /usr/share/doc/lessfs-1.0.0/copying 2) Still used direct path in several places: # install SYSV init stuff mkdir -p %{buildroot}/etc/rc.d/init.d install -m755 etc/lessfs %{buildroot}/etc/rc.d/init.d/lessfs install -D -m 644 etc/lessfs.cfg %{buildroot}/etc/lessfs.cfg 3) lib_qlz.{c,h} still in tarball. I saw BR lzo-devel and --with-lzo configure parameter, and if you aree shure it is not used anymore it should be deleted in %prep. 4) lib_BMW.c, lib_sboxes.c, lib_net.{h,c}, lib_tiger.c, listdb.c became part of lessfs and not really libraries? It is clarified by upstream author? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review