Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523650 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rdieter@xxxxxxxxxxxx Flag| |fedora-review?, | |needinfo?(glua@xxxxxxxxxx) --- Comment #32 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2010-01-20 16:06:47 EST --- SHOULD: drop "Qt4 based" from package summary/description. (hardly) anyone cares what toolkit is used, as long as the application works. MUST: drop Requires: qt not needed MUST: fix desktop-file-install usage (see also http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files) 1. don't use '--add-category X-Fedora' 2. no need to run both desktop-file-install *and* desktop-file-validate (the former is sufficient). MUST: update icon-related scriptlets, see, http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache MUST: please install qmpdclient64.png icon too (most DE's don't handle svg icons well or at all) MUST: please adjust the patch to drop QMAKE_LFLAGS_RELEASE adjustments completely. These are not needed or desired either (this part should be upstreamable, they shouldn't be mucking with these flags). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review