Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556625 --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-01-19 22:44:03 EST --- Review: Good: - name ok - group ok - builds cleanly - %check is there - %clean is there - no static libs - *.so.* in package - *.so in devel - license ok - %doc ok - no *.la - rpmlint ok: $ rpmlint milia-0.3.0-1.fc12.src.rpm x86_64/* milia-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 1 warnings. Cosmetic issues (Should): - Could you delete all *.la files in %install? Like: find -name '*.la' | xargs rm -f %exclude .../*.la is ok, too. Blocker: - BR: pkgconfig is not needed anymore (except you want to build in EPEL) But then, but this BR into the *subpackage*. If you build for fedora, delete it. - permissions: you missed the last ',-' in %defattr(-,root,root,-) of -devel - sources do not match upstream: your sources: f54fde2157cc213aebf676ac84e3684e upstream: ff0d1a97d14548bc1ac215638f6d1cf8 What have you done? ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review