[Bug 555161] Review Request: csisat - Tool for LA+EUF Interpolation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555161

--- Comment #9 from David A. Wheeler <dwheeler@xxxxxxxxxxxx> 2010-01-19 17:05:42 EST ---
Everything looks good now!

It looks like you addressed all the comments above.

The parallel build works now.   I rebuilt three times, to try to trigger race
conditions, and I saw no evidence of problems.

It seems to run fine.  I tried it both using the built-in SAT solver, and using
the picoSAT SAT solver. To test it out, I used two test situations.
Test #1: Satisfiable
 a > 0 ;
 a < 4
Test #2: Unsatisfiable
a > 0 ; 
a < 0

I used -sat in all cases, and for both test situations I ran two test cases
(pico and non-pico).... I used "-SATsolver pico" for pico.
They all produced the correct results.

rpmlint for this updated package is clean:
 rpmlint csisat.spec ../RPMS/x86_64/csisat-* ../SRPMS/csisat-1.2-2.fc12.src.rpm 
3 packages and 1 specfiles checked; 0 errors, 0 warnings.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]