Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556611 --- Comment #8 from John W. Linville <linville@xxxxxxxxxx> 2010-01-19 13:55:18 EST --- > I am unsure, imho 1.%{date}git%{commitid}%{?dist} is ugly. Nevertheless, it follows the example in the packaging guidelines. > why is release starting with 1, it should start with 3 by now? I regenerated the tarball, changing the date. So it followed this progression: 1.20100118git599b03bfd1294 2.20100118git599b03bfd1294 1.20100119git599b03bfd1294 Since I'm hitting the spec anyway, I'll change it to avoid further confusion. > mixing %{}- and $-style macros, change $RPM_OPT_FLAGS to %{optflags} OK... > A guy called Patrick Ohly is doing a fork and now you have your own fork > on git.infradead.org? Patrick Ohly works (or at least worked) for Intel. After the SourceForge guys disappeared, he sent his changes to me. I presume that he will send any further contributions to me, so there is no "fork" there. The SourceForge guys abandoned the project, so as far as I'm concerned my tree on Infradead isn't a "fork" either -- the project merely moved. The tree on Infradead is the consolidated result. Spec URL: http://linville.fedorapeople.org/ptpd.spec SRPM URL: http://linville.fedorapeople.org/ptpd-1.0.0-4.20100119git599b03bfd1294.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review