Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521716 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-01-18 10:53:30 EST --- Review: Good: - name ok - BR ok - %build ok - %clean there - %doc ok - no *.la - no static libs - permissions ok - rpmlint clean Needswork: - %install: why don't you need the cmdtools? Make at least a comment in the spec. - %check section would be great, then you'd found out the next issue: - missing Requires: pyutil which is not yet in fedora... Also see the file zfec/filefec.py, there is also an import pyutil. I didn't test the programm, if it works, but it doesn't look like. Did you try it, or are you just packaging it as dependendy? Or did you remove the cmdtools because of this missing dependency? Better package that first, and enable all feature it has... - Be a bit more explicit in %files: %{python_sitearch}/%{name} and %{python_sitearch}/%{name}*.egg-info would be better. - Query upstream to add license headers. - Are the patches upstream -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review