Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226350 --- Comment #2 from Daniel Novotny <dnovotny@xxxxxxxxxx> 2010-01-18 07:35:45 EST --- OK source files match upstream: 1f7655050cebbb664db976405fdba209 PyXML-0.8.4.tar.gz OK source contains full URL OK package meets naming and versioning guidelines. Packages of python modules (thus they rely on python as a parent) use a slightly different naming scheme. They should take into account the upstream name of the python module. This makes a package name format of python-$NAME. When in doubt, use the name of the module that you type to import it in a script. There is an exception to this rule. If the upstream source has "py" (or "Py") in its name, you can use that name for the package. So, for example, pygtk is acceptable. => PyXML is acceptable OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license (MIT and Python and ZPLv1.0 and BSD). OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock. OK debuginfo package looks complete. BAD rpmlint is silent. rpmlint on spec is OK, rpmlint on rpms yields: PyXML.i386: E: non-executable-script /usr/lib/python2.6/site-packages/_xmlplus/xslt/_4xslt.py 0644 /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. PyXML.i386: E: non-executable-script /usr/lib/python2.6/site-packages/_xmlplus/dom/html/GenerateHtml.py 0644 /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. PyXML.i386: E: non-executable-script /usr/lib/python2.6/site-packages/_xmlplus/dom/ext/c14n.py 0644 /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. - adding the x bit will imho fix this PyXML.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/PyXML-0.8.4/xmlproc/standard.css This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. - please examine the file PyXML.i386: W: file-not-utf8 /usr/share/doc/PyXML-0.8.4/CREDITS The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). PyXML.i386: W: file-not-utf8 /usr/share/doc/PyXML-0.8.4/xml-howto.txt The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). PyXML.i386: W: file-not-utf8 /usr/share/doc/PyXML-0.8.4/xml-ref.txt The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). PyXML.i386: W: file-not-utf8 /usr/share/doc/PyXML-0.8.4/README The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). PyXML.i386: W: file-not-utf8 /usr/share/doc/PyXML-0.8.4/ANNOUNCE The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). -these are probably plaintext files, so that's OK PyXML.i386: W: file-not-in-%lang /usr/lib/python2.6/site-packages/_xmlplus/dom/de/LC_MESSAGES/4Suite.mo PyXML.i386: W: file-not-in-%lang /usr/lib/python2.6/site-packages/_xmlplus/dom/en_US/LC_MESSAGES/4Suite.mo PyXML.i386: W: file-not-in-%lang /usr/lib/python2.6/site-packages/_xmlplus/dom/fr/LC_MESSAGES/4Suite.mo -the %lang tag seems to be removed in Bug 113268 please investigate. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. - they are in the library directory, which is OK OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. overall OK, except for the rpmlint errors also, in %files section %defattr(-,root,root) is deprecated, please use %defattr(-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review