Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xorg-x11-xcalc - X.org XCalc https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204513 ------- Additional Comments From pertusus@xxxxxxx 2006-10-08 17:39 EST ------- Still some issues: * in the .desktop file I think the Version doesn't seems to be for the software version, but maybe to show conformance to a specification version. Just remove it or have a look at the freedesktop standard. * the icon is not placed rightly. It should better be in %{_datadir}/icons/hicolor/48x48/apps/xcalc.png * you should then use the scriplet http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda * this is only a remark, not a blocker, but I prefer using install over cp, since with install you can set explicitely the permissions you want with -m. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review