Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518779 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-01-17 05:59:01 EST --- Since there are several important changes compared to the previous version, I rechecked the complete package. I couldn't find anything to complain about, so the package is approved. :) --------------------------------- keys used in following checklist: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - LGPL v3 according to COPYING and boilerplates [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: File(s) containing the text of the license(s) must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ sha1sum libnfc-1.3.0.tar.gz* f4e0b746ecfe0e4ce446812eaf785a29bcc91b84 libnfc-1.3.0.tar.gz f4e0b746ecfe0e4ce446812eaf785a29bcc91b84 libnfc-1.3.0.tar.gz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1927878 [.] MUST: If the package does not successfully compile, ... [+] MUST: All build dependencies must be listed in BuildRequires ... [.] MUST: The spec file MUST handle locales properly. - no locales [+] MUST: Packages containing shared libraries files must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... - not relocatable [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot}. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc section must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' [+] MUST: .so files w/o suffix must go in a -devel package. [+] MUST: devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}. [+] MUST: All filenames in rpm packages must be valid UTF-8. [+] SHOULD: The reviewer should test that the package builds in mock. - build in mock [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. - builds in koji [+] SHOULD: The reviewer should test that the package functions as described. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [+] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. ======================== The package is APPROVED. ======================== -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review