Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553205 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |iarnell@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2010-01-17 03:41:09 EST --- + source files match upstream. 203bc410ae5040e7b647a52aa0fabafe Error-0.17015.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. - latest version is being packaged. 0.17016 is available + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock https://koji.fedoraproject.org/koji/buildinfo?buildID=145298 + package installs properly. + rpmlint has no complaints: perl-Error.noarch: I: checking perl-Error.src: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(Error) = 0.17015 perl(Error::Simple) perl(Error::WarnDie) perl(Error::subs) perl-Error = 1:0.17015-4.fc13 = perl >= 0:5.004 perl(:MODULE_COMPAT_5.10.1) perl(Error) perl(Exporter) perl(Scalar::Util) perl(overload) perl(strict) perl(vars) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 rpmlib(VersionedDependencies) <= 3.0.3-1 + %check is present and all tests pass. All tests successful. Files=15, Tests=64, 1 wallclock secs ( 0.05 usr 0.02 sys + 0.49 cusr 0.19 csys = 0.75 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED - only minor problem is that this isn't the latest upstream version - 0.17016 is available. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review