Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555991 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rdieter@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2010-01-16 16:17:48 EST --- A few quick initial comments: 1. probably only really need BuildRequires: kdelibs4-devel (unverified, unless you know better) 2. in %install, use make install/fast DESTDIR=%{buildroot} -C %{_target_platform} intead 3. in %install, no need for .la file hackery. kde4/cmake produces none. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review