Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550143 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #11 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-01-16 12:58:56 EST --- Some notes: * Source - Source tarball contained in your srpm does not coincide with what I could download from the URL written in your spec file: ----------------------------------------------------------- 181106 2009-12-22 18:07 downloaded/webattery-1.1.tar.gz 180043 2009-12-24 04:59 webattery-1.1-5.fc10.src/webattery-1.1.tar.gz ----------------------------------------------------------- * CFLAGS - 'CFLAGS="%{optflags}"' on "make" line is not needed as %configure correctly sets this value ( see what %configure actually does by $ rpm --eval %configure ) * Timestamp - Please consider to use ----------------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" ----------------------------------------------------------- to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools. ! warnings - By the way, would you take care of these warnings? ----------------------------------------------------------- 92 webattery.c:266: warning: format '%s' expects type 'char *', but argument 4 has type 'const char (*)[4]' 93 webattery.c:270: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[15]' 94 webattery.c:276: warning: format '%s' expects type 'char *', but argument 4 has type 'const char (*)[4]' 95 webattery.c:282: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[30]' 96 webattery.c:282: warning: format '%s' expects type 'char *', but argument 4 has type 'const char (*)[4]' 97 webattery.c:287: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[20]' 98 webattery.c:293: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[40]' 99 webattery.c:293: warning: format '%s' expects type 'char *', but argument 4 has type 'const char (*)[3]' 100 webattery.c:299: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[20]' 101 webattery.c:299: warning: format '%s' expects type 'char *', but argument 4 has type 'const char (*)[4]' 102 webattery.c:305: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[20]' 103 webattery.c:305: warning: format '%s' expects type 'char *', but argument 4 has type 'const char (*)[4]' 104 webattery.c:309: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[20]' 105 webattery.c:315: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[20]' 106 webattery.c:315: warning: format '%s' expects type 'char *', but argument 4 has type 'const char (*)[20]' 107 webattery.c:319: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[20]' 108 webattery.c:323: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[20]' 109 webattery.c:327: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[20]' 110 webattery.c:333: warning: format '%s' expects type 'char *', but argument 4 has type 'const char (*)[3]' 111 webattery.c:339: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[20]' 112 webattery.c:339: warning: format '%s' expects type 'char *', but argument 4 has type 'const char (*)[3]' ----------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review