Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xorg-x11-xcalc - X.org XCalc https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204513 ------- Additional Comments From pertusus@xxxxxxx 2006-10-08 09:57 EST ------- In my opinion, the name may be xcalc and not xorg-x11-xcalc. Indeed the xorg-x11- prefix is used for collection of softwares, or to disambiguate with regard with other implementations, so I guess here it is not required. Therefore you can, if you prefer, use xcalc as name and Provides: xorg-x11-xcalc. For the provides, you can also use the %{version} to avoid having to change it at each release: Provides: xcalc = %{version} You don't have to define the x11_app_defaults_dir, you can, at your will define it like you did, or simply have in %files: %{_datadir}/X11/app-defaults/XCalc %{_datadir}/X11/app-defaults/XCalc-color In %files, I personally prefer to use glob for man pages extensions, to catch the case of no compression or compression using different schemes. If you like it you can change to %{_mandir}/man1/xcalc.1x* The COPYING file is empty, so the licence should be found by reading the individual file licences. All of the files are under the X11 licence, except math.c which don't have a licence, but some authors, which are also copyright owners unless otherwise stated. As the default licence is like a proprietary licence, this is not good for inclusion in fedora. It is likely, however, that before the split, this package was included in a package with proper COPYING and licence information. My personnal opinion is that upstream should be asked for clarification, and otherwise licence information from older releases should be found and used. libXaw-devel requires libXt-devel and libXpm-devel, libXt-devel requires libSM-devel and libX11-devel, so, optionally, you can remove libXt-devel, libXpm-devel, libSM-devel and libX11-devel from BuildRequires. The only blocker item is the license issue for math.c. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review