[Bug 552557] Merge Review: perl-Config-Tiny - Perl module for reading and writing .ini style configuration files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552557

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-01-15 01:52:27 EST ---

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1923052
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
45360fdf2bd263fdb090d833a09ba3bc7e8578f8  Config-Tiny-2.12.tar.gz
+ package meets naming and packaging guidelines.
+ make test gave
All tests successful.
Files=4, Tests=36,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.18 cusr  0.04
csys =  0.25 CPU)
+ Package perl-Config-Tiny-2.12-7.fc13.noarch =>
Provides: perl(Config::Tiny) = 2.12
Requires: perl(strict)

Suggestions
1)change line
chmod -R u+w $RPM_BUILD_ROOT/*
to
%{_fixperms} $RPM_BUILD_ROOT/*

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]