Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=552253 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-01-15 01:52:37 EST --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1923050 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 65da2c1067184f31f906d6c12cd6870e740d8d44 Test-MockObject-1.09.tar.gz + package meets naming and packaging guidelines. + make test gave All tests successful. Files=9, Tests=216, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.37 cusr 0.07 csys = 0.51 CPU) + Package perl-Test-MockObject-1.09-4.fc13.noarch => Provides: perl(Test::MockObject) = 1.09 perl(Test::MockObject::Extends) = 1.09 Requires: perl(Devel::Peek) perl(Scalar::Util) perl(Test::Builder) perl(Test::MockObject) perl(UNIVERSAL::can) perl(UNIVERSAL::isa) perl(strict) perl(vars) perl(warnings) Suggestions: 1) add following line find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';' 2) change line chmod -R u+w $RPM_BUILD_ROOT/* to %{_fixperms} $RPM_BUILD_ROOT/* APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review