[Bug 553483] Review Request: dogtag-pki-console-ui - The Dogtag PKI Console User Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553483

--- Comment #4 from Matthew Harmsen <mharmsen@xxxxxxxxxx> 2010-01-14 18:04:36 EST ---
> Please document bug id and some information in pki-common SPEC file. And yes
> you can also add in description that "this package conflicts with
> tomcat-native"
> Guidelines says "include the reasoning in a comment next to the Conflicts:
> entry, so that it will be abundantly clear why it needed to exist."
> Also, not sure whether we need to ask FESCo for approval of this Conflicts
> usage though I see its correct reason to use it.

We removed "Conflict: tomcat-native" from the 'pki-common' package (which will
be re-spun), and added "Conflict: tomcat-native", preceded it by a descriptive
comment which referenced Bugzilla Bug #441974, and augmented the "%description"
section in the lower-level 'tomcatjss' package (which will also be re-spun).

> I suggested removing "Requires: bash" in pki-common review also. This is false
> assumption that rpmbuild needs at least one "Requires". Please remove this from
> all packages waiting for review.

Done.  (no UI components reference 'bash' - 7 of the 8 UI components will be
re-spun -- dogtag-pki-console-ui did not previously contain this reference)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]