Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533594 --- Comment #7 from Dwayne Bailey <dwayne@xxxxxxxxxxxxxxxx> 2010-01-14 09:43:04 EST --- (In reply to comment #5) > Checking Packaging Guidelines, can you address the following: > * Instead of using /usr/sbin etc in the %install section, you should use > {%_sbindir} - see http://fedoraproject.org/wiki/Packaging:RPMMacros I converted these all to macros in the new spec > Checking Packaging Guidelines, can you verify/comment on the following: > * BuildRoot, and rm -rf ${RPM_BUILD_ROOT} are not required in Fedora 10 and > higher, but you can keep them in if you need to for earlier versions I will want to package for EL5 so I'd rather leave this in now. All there references I can find include rm -rf in both the %install and %clean sections as I have. > * The source tarball includes translations in separate po and mo directories - > the Packaging Guidelines say "Keep in mind that usage of %find_lang in packages > containing locales is a MUST." - can you comment on why they are just copied > with the install The mo files for Django are stored in /usr/share/pootle/mo instead of the more standard /usr/share/locale/ this is an issue with Django I'm afraid. We don't mess with these as we don't need them to be specifically platform compiled as they will work correctly with Django, so no need to compile or recompile. The po files are stored in /var/lib/pootle/po/pootle as this allows them to be translated live as a demo of how Pootle can be used to translate. Again a non standard location but these are at least in the correct area for translations. > * I'm curious as to why you cp -p %{SOURCE2} . instead of to a target > directory - everything else is copied to the build root I need this available for the %files section to be added to docs. I don't want into installed into the BuildRoot I'll upload a new spec file, thanks a mill for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review