Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533594 --- Comment #5 from David Fraser <davidf@xxxxxxxxxx> 2010-01-14 08:56:57 EST --- Checking Packaging Guidelines, can you address the following: * Instead of using /usr/sbin etc in the %install section, you should use {%_sbindir} - see http://fedoraproject.org/wiki/Packaging:RPMMacros Checking Packaging Guidelines, can you verify/comment on the following: * BuildRoot, and rm -rf ${RPM_BUILD_ROOT} are not required in Fedora 10 and higher, but you can keep them in if you need to for earlier versions * The source tarball includes translations in separate po and mo directories - the Packaging Guidelines say "Keep in mind that usage of %find_lang in packages containing locales is a MUST." - can you comment on why they are just copied with the install * I'm curious as to why you cp -p %{SOURCE2} . instead of to a target directory - everything else is copied to the build root Checked the Packaging Guidelines, no change needed: * Verified that all the requirements are in fact necessary * Verified that config files are marked appropriately -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review