Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544739 Thomas Janssen <thomasj@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thomasj@xxxxxxxxxxxxxxxxx --- Comment #8 from Thomas Janssen <thomasj@xxxxxxxxxxxxxxxxx> 2010-01-13 16:57:31 EST --- Ok, i'm happy to do the pre-review. A new version, like here the change from 0.1.4 to 0.1.5 restarts the release with 1. Means you're currently at 0.1.5-2 Remove from changelog the fedora 12 betabuild entry. You missed to bump the release anyways and have two 0.1.4-1 Url should be: http://wiki.github.com/dmacvicar/kopete-facebook instead of http://kopete.kde.org/ The >= 4.2 for the kde BRs are redundant and can be removed. The BRs needed are: qjson-devel, kdenetwork-devel The rest is redundant and can be removed. You can remove the Provides and Obsoletes lines as well. Remove the redundant %post and %postun ldconfig lines. This is not a shlib, so not needed. In %files, use please kde4 macros as provided in: http://fedoraproject.org/wiki/SIGs/KDE#Best_Practices I will do a full review later. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review