Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gotmail https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199905 ------- Additional Comments From pertusus@xxxxxxx 2006-10-07 17:44 EST ------- When you update the spec file you should rebuild a .src.rpm and put it on the web. * You can drop Epoch: 0 from the spec file. * a release of 0 is not right, if I recall well, you should set it to 1 and increase it during review, or alternatively, some packagers set it to 0.1 and increase it to 0.2 and so on during review and set it to 1 when imported in cvs. * You misunderstood my comment about perl requires being autodetected. I meant that Requires: perl >= 5 is certainly not needed. * the following are set automatically: %define __find_provides /usr/lib/rpm/find-provides.perl %define __find_requires /usr/lib/rpm/find-requires.perl * in the comment about -n I talked about -n and its argument, not -n on its own. The %setup line is wrong now. * the release is missing from the changelog entries. It is not a blocker, but in general the changelog entries are like 0.8.9-0, or 0.8.9-1 once you have corrected the release... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review