[Bug 529496] Review Request: libmtag - An advanced C music tagging library with a simple API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529496

--- Comment #36 from Felipe Contreras <felipe.contreras@xxxxxxxxx> 2010-01-13 07:55:11 EST ---
(In reply to comment #34)
> Package still does not build:

[...]

> Apparently you don't test the stuff you want us to review.

Why do you have to assume the worst? Maybe you should try to think of another
non-antagonist option (hint: 64).

> => NEW: MUSTFIX: Package doesn't honor RPM_OPT_FLAGS

Ok, fixed:
make V=y CFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags}

> Well, you are not the first person who is outsmarting himself by using
> handwritten makefiles.

That's an uncalled for assumption, and ad hominem attack. What do you even know
about me?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]