[Bug 529496] Review Request: libmtag - An advanced C music tagging library with a simple API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529496

--- Comment #29 from Felipe Contreras <felipe.contreras@xxxxxxxxx> 2010-01-13 05:22:26 EST ---
(In reply to comment #28)
> MUSTFIX:
> 
> * Package doesn't build in mock:

[...]

> /usr/bin/ld: lib/mtag.o: relocation R_X86_64_32 against `.rodata' can not be
> used when making a shared object; recompile with -fPIC

Oops, fixed.

> * Spec-filename ("libmtag-1.spec") doesn't comply to Fedora conventions.

libmtag.spec, right? If so, fixed.

> * Building is non-verbose (cf. above).

Fixed.

> * autoreconf -fi fails == Upstream tarball is broken.

You mean that I forgot to remove configure.ac? Fixed.

> From what I see, you abandoned using automake and switched to using manually
> written Makefiles. Likely you believe this to be a good idea ... I don't.

Well, that's your opinion, you are entitled to it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]