Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554603 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Kevin Fenzi <kevin@xxxxxxxxx> 2010-01-12 16:13:43 EST --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (LGPLv2+ and GFDL1.1) See below - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: d41255b631f505b26171317d872762ed garcon-0.1.0.tar.bz2 d41255b631f505b26171317d872762ed garcon-0.1.0.tar.bz2.orig See below - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Headers/static libs in -devel subpackage. OK - Spec has needed ldconfig in post and postun OK - .pc files in -devel subpackage/requires pkgconfig OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} OK - .la files are removed. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. The License tag should just have "LGPLv2+ and GFDL". We don't seem to note versions on the GFDL. 2. This packge has the same: checking whether to build gtk-doc documentation... no but it builds it anyhow. 3. rpmlint says: Ignore: garcon.i586: W: spelling-error-in-summary en_US freedesktop garcon.i586: W: spelling-error-in-description en_US freedesktop garcon.i586: W: spelling-error-in-description en_US Xfce garcon.i586: W: spelling-error-in-description en_US libxfce garcon.i586: W: spelling-error-in-description en_US GLib garcon.src: W: spelling-error-in-summary en_US freedesktop garcon.src: W: spelling-error-in-description en_US freedesktop garcon.src: W: spelling-error-in-description en_US Xfce garcon.src: W: spelling-error-in-description en_US libxfce garcon.src: W: spelling-error-in-description en_US GLib Fix by using "GFDL" only there. garcon.i586: W: invalid-license GFDL1.1 garcon.src: W: invalid-license GFDL1.1 garcon-debuginfo.i586: W: invalid-license GFDL1.1 garcon-devel.i586: W: invalid-license GFDL1.1 The license tag can be fixed on import and the gtk-doc thing is just a curiosity, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review