Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225889 --- Comment #2 from Kamil Dudka <kdudka@xxxxxxxxxx> 2010-01-12 12:18:53 EST --- OK == - almost silent rpmlint (only some spelling false alarms) - valid project URL and source URL - upstream tarball is the same as the one from look-aside cache - md5 hash matches the sources - dist tag OK - BuildRoot tag OK - license tag OK (though valid only for the contrib directory, all other is LGPLv2+ licensed) - all patches from CVS are applied - configure options OK - make options OK - %clean OK - %files OK - %doc OK may be better ============= - 9 lines of the description are the same for htdig and htdig-web subpackage; it would be good to define it as a macro, so that it can be maintained at one place. - explicit BuildRequires for flex should be either commented, or better made non-explicit - redundant BuildRequires for autoconf and automake (already required by libtool) - some patches lack link to upstream thread - hard-link creation deserves a comment (perhaps should be a symlink instead?) - %defattr(-,root,root) should be %defattr(-,root,root,-) - ldconfig is not called at all - I suggest to add following: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig - the option -r of rm may be omitted in the following commands rm -rf $RPM_BUILD_ROOT%{_libdir}/htdig/*.a rm -rf $RPM_BUILD_ROOT%{_libdir}/htdig/*.la rm -rf $RPM_BUILD_ROOT%{_libdir}/htdig_db/*.a rm -rf $RPM_BUILD_ROOT%{_libdir}/htdig_db/*.la -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review