Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225639 Karel Klíč <kklic@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(npajkovs@xxxxxxxx | |om) --- Comment #19 from Karel Klíč <kklic@xxxxxxxxxx> 2010-01-12 10:35:50 EST --- [???] source0 Fedora guideline https://fedoraproject.org/wiki/Packaging:SourceURL says, that links to SourceForge should use http://downloads.sourceforge.net/, but this package uses http://prdownloads.sourceforge.net [YES] source files match upstream: 70d6547795a1342631c7ab56709fd1940c2aff9f cdrdao-1.2.3.tar.bz2 [YES] package meets naming and versioning guidelines [YES] specfile is properly named, is cleanly written and uses macros consistently [YES] dist tag is present [YES] build root is correct [???] license field matches the actual license The license field says GPLv2, but the source code files in directories dao, trackdb, xdao, and utils states that the software is under GPLv2+. Jörg mentioned some legal problems -- as far as I can tell, those are outside of scope of this review. All files in the source package seems to be released under open source license. [YES] license is open source-compatible [YES] license text included in package [YES] latest version is being packaged [YES] BuildRequires are proper [???] configure flags are appropriate Parameter --with-mp3-support is used, but configure script does not find libmad, so MP3 support is (correctly) disabled at the end. Also the option with_mp3_support is enabled by default, even without the parameter. IMHO it would be better to use --without-mp3-support [YES] compiler flags are appropriate [YES] %clean is present [YES] package builds in mock [YES] debuginfo package looks complete [NO] rpmlint is silent $ rpmlint *.rpm cdrdao.i686: W: file-not-utf8 /usr/share/doc/cdrdao-1.2.3/CREDITS gcdmaster.i686: W: non-conffile-in-etc /etc/gconf/schemas/gcdmaster.schemas 4 packages and 0 specfiles checked; 0 errors, 2 warnings. The rpmlint output seems ok to me. [YES] final provides and requires look sane [OK] no %check is present [OK] no shared libraries are added to the regular linker search paths in app package [OK] owns the directories it creates [OK] doesn't own any directories it shouldn't [YES] no duplicates in %files [YES] file permissions are appropriate [YES] scriptlets ok [YES] code, not content [YES] documentation is small, so no -docs subpackage is necessary [YES] %docs are not necessary for the proper functioning of the package [YES] no headers [YES] no pkgconfig files [YES] no libtool .la droppings -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review